pitrou commented on code in PR #47663:
URL: https://github.com/apache/arrow/pull/47663#discussion_r3152451678
##########
cpp/src/arrow/csv/options.cc:
##########
@@ -43,6 +43,7 @@ ConvertOptions ConvertOptions::Defaults() {
"NULL", "NaN", "n/a", "nan", "null"};
options.true_values = {"1", "True", "TRUE", "true"};
options.false_values = {"0", "False", "FALSE", "false"};
+ options.default_column_type = nullptr;
Review Comment:
This is harmless, but also unnecessary since this will be the default
("uninitialized") value anyway.
##########
cpp/src/arrow/csv/options.h:
##########
@@ -76,6 +76,8 @@ struct ARROW_EXPORT ConvertOptions {
bool check_utf8 = true;
/// Optional per-column types (disabling type inference on those columns)
std::unordered_map<std::string, std::shared_ptr<DataType>> column_types;
+ /// Default type to use for columns not in `column_types`
Review Comment:
```suggestion
/// Default type to use for columns not in `column_types`
///
/// If set, this disables type inference on all columns.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
