HippoBaro commented on PR #9846:
URL: https://github.com/apache/arrow-rs/pull/9846#issuecomment-4339762014

   This PR adds benchmarks with a custom `Measurement`. In this case, we 
measure RSS and cumulative memory usage (target `arrow_reader_peak_memory`).
   
   I am not sure if the benchmark bot will like those new units:
   
   ```
   arrow_array_reader/ListArray_peak_memory/Int32List/no NULLs
                           time:   [836.51 KiB 836.51 KiB 836.51 KiB]
   arrow_array_reader/ListArray_peak_memory/Int32List/half NULLs
                           time:   [482.01 KiB 482.01 KiB 482.01 KiB]
   arrow_array_reader/ListArray_peak_memory/Int32List/90pct NULLs
                           time:   [271.95 KiB 271.95 KiB 271.95 KiB]
   arrow_array_reader/ListArray_peak_memory/Int32List/99pct NULLs
                           time:   [217.96 KiB 217.96 KiB 217.96 KiB]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to