CurtHagenlocher commented on code in PR #342:
URL: https://github.com/apache/arrow-dotnet/pull/342#discussion_r3161575812
##########
src/Apache.Arrow.Operations/VariantJson/VariantJsonConverter.cs:
##########
@@ -243,10 +243,7 @@ internal static void WriteValue(Utf8JsonWriter writer,
VariantValue value)
writer.WriteNumberValue(value.AsDecimal());
break;
case VariantPrimitiveType.Decimal16:
- if (value.IsSqlDecimalStorage)
- writer.WriteRawValue(value.AsSqlDecimal().ToString());
- else
- writer.WriteNumberValue(value.AsDecimal());
+ writer.WriteRawValue(value.AsSqlDecimal().ToString());
Review Comment:
`SqlDecimal.ToString` is not culture-sensitive. Added comment calling this
out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
