justing-bq commented on code in PR #49766:
URL: https://github.com/apache/arrow/pull/49766#discussion_r3164485804
##########
cpp/src/arrow/flight/sql/odbc/CMakeLists.txt:
##########
@@ -159,6 +158,66 @@ if(ARROW_FLIGHT_SQL_ODBC_INSTALLER)
set(CPACK_WIX_UI_BANNER
"${CMAKE_CURRENT_SOURCE_DIR}/install/windows/arrow-wix-banner.bmp")
+ else()
+ if(APPLE)
+ set(CPACK_PACKAGE_FILE_NAME
+
"ArrowFlightSqlOdbc-${CPACK_PACKAGE_VERSION_MAJOR}.${ODBC_PACKAGE_VERSION_MINOR}.${ODBC_PACKAGE_VERSION_PATCH}"
Review Comment:
I'm curious what other locations you are referring to?
In situations where we use CamelCase naming but some of the words are
acronyms like `SQL` and `ODBC`, the convention is to treat those acronyms like
any other word in the name. ie. `ArrowFlightSqlOdbc`.
So if there are other locations where we are using `SQLODBC`, I would prefer
to update those to `SqlOdbc` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
