westonpace opened a new pull request #10272:
URL: https://github.com/apache/arrow/pull/10272
This allows the user to supply an optional `mask` when creating a struct
array.
* The mask requirements are pretty strict (must be a boolean arrow array
without nulls) compared with some of the other functions (e.g. `array.mask`
accepts a wide variety of inputs). I think this should be ok since this use
case is probably rarer and there are other plenty of existing ways to convert
other datatypes to an arrow array.
* Unfortunately, StructArray::Make interprets the "null buffer" as more of
a validity buffer (1 = valid, 0 = null). This is the opposite of everywhere
else a `mask` is used. I was torn between inverting the input buffer to mimic
the python API and passing through directly to the C interface for simplicity.
I chose the simpler option but could be convinced otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
