HippoBaro commented on code in PR #9847:
URL: https://github.com/apache/arrow-rs/pull/9847#discussion_r3174270952


##########
parquet/src/arrow/array_reader/struct_array.rs:
##########
@@ -224,39 +224,27 @@ impl ArrayReader for StructArrayReader {
 mod tests {
     use super::*;
     use crate::arrow::array_reader::ListArrayReader;
-    use crate::arrow::array_reader::test_util::InMemoryArrayReader;
+    use crate::arrow::array_reader::test_util::make_int32_page_reader;
     use arrow::buffer::Buffer;
     use arrow::datatypes::Field;
     use arrow_array::cast::AsArray;
-    use arrow_array::{Array, Int32Array, ListArray};
+    use arrow_array::{Array, ListArray};
     use arrow_schema::Fields;
 
     #[test]
     fn test_struct_array_reader() {
-        let array_1 = Arc::new(Int32Array::from(vec![1, 2, 3, 4, 5]));
-        let array_reader_1 = InMemoryArrayReader::new(
-            ArrowType::Int32,
-            array_1.clone(),
-            Some(vec![0, 1, 2, 3, 1]),
-            Some(vec![0, 1, 1, 1, 1]),
-        );
+        let array_reader_1 = make_int32_page_reader(&[4], &[0, 1, 2, 3, 1], 
&[0, 1, 1, 1, 1], 3, 1);

Review Comment:
   Oh that would be lovely 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to