SAY-5 opened a new pull request, #797:
URL: https://github.com/apache/arrow-go/pull/797

   Closes #785.
   
   `CreateSetLookupState` already routes `FixedSizeBinary` widths 1/2/4/8 onto 
the numeric fast path (`SetLookupState[uintN]` + `visitNumeric[uintN]`), but 
`Init` then asked `newMemoTable` for `arrow.FIXED_SIZE_BINARY` and got a 
`BinaryMemoTable`, which fails the subsequent `TypedMemoTable[uintN]` 
assertion. The cleanup hook had the same blind spot — it cast every state to 
`SetLookupState[[]byte]` and would have panicked there too once Init was fixed.
   
   Map the FSB byte-width to the matching uint type before the lookup, and only 
release in `CleanupFn` when the state actually carries a `BinaryMemoTable`. 
Adds a regression test exercising widths 1/2/4/8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to