alamb commented on code in PR #9905:
URL: https://github.com/apache/arrow-rs/pull/9905#discussion_r3188663799
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -159,12 +160,12 @@ impl FixedSizeBinaryArray {
}
};
- Self::validate_lengths(s, len)?;
+ Self::validate_lengths(value_size, len)?;
Ok(Self {
data_type,
value_data: values,
- value_length: size,
+ value_length,
Review Comment:
here is an example of inconsistent terminology `size` and `value_length`
used for the same concept
After this PR, the same concept has the same name in both parameters and
fields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
