etseidl commented on code in PR #9868:
URL: https://github.com/apache/arrow-rs/pull/9868#discussion_r3189142070
##########
parquet/src/parquet_thrift.rs:
##########
@@ -317,7 +329,13 @@ pub(crate) trait ThriftCompactInputProtocol<'a> {
// high bits set high if count and type encoded separately
possible_element_count as i32
} else {
- self.read_vlq()? as _
+ // The list size on the wire is an unsigned varint, but we
represent
+ // it as `i32` (matching Java's `int` and the Parquet Thrift
schema).
Review Comment:
```suggestion
// The list size on the wire is an unsigned varint, but we
represent
// it as `i32` (matching Java's `int` and the Thrift schema).
```
This is actually at the Thrift compact protocol layer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
