alamb commented on code in PR #9891:
URL: https://github.com/apache/arrow-rs/pull/9891#discussion_r3189220924


##########
arrow-arith/src/temporal.rs:
##########
@@ -194,6 +195,15 @@ pub fn date_part(array: &dyn Array, part: DatePart) -> 
Result<ArrayRef, ArrowErr
             let new_array = array.with_values(values);
             Ok(new_array)
         }
+        DataType::RunEndEncoded(k, _) => match k.data_type() {

Review Comment:
   In general I would prefer separate small PRs (they do actually get reviewed 
and merged faster !)



##########
arrow-array/src/array/run_array.rs:
##########
@@ -30,6 +30,25 @@ use crate::{
     types::{Int16Type, Int32Type, Int64Type, RunEndIndexType},
 };
 
+/// Recursively applies a function to the values of a RunEndEncoded array, 
preserving the run structure.
+///
+/// # Example
+///
+/// ```ignore
+/// let result = ree_recurse!(array, Int32Type, my_function)?;
+/// ```
+///
+/// This macro is useful for implementing functions that should work on the 
logical values
+/// of a REE array while preserving the run-end encoding structure.
+#[macro_export]
+macro_rules! ree_map {

Review Comment:
   - Filed https://github.com/apache/arrow-rs/issues/9909



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to