alamb opened a new issue, #9921:
URL: https://github.com/apache/arrow-rs/issues/9921
As an API suggestion (maybe for another PR, not required):
I would personally find this much easier to understand if the fields were
named so I didn't have to refer to `make_int32_page_reader` to figure out
what`&[0, 1, 2, 3, 1]` and `&[0, 1, 1, 1, 1]` meant.
Perhaps we could do this with an builder in the test. Something like this
perhaps:
```rust
let array_reader_1 = TestArrayReaderBuilder::new()
.with_non_null_i32_values(&[4]) // <-- this is especially non obvous if you
are used to normal Arrow arrays
.with_def_levels(&[0, 1, 2, 3, 1])
.with_rep_levels(&[0, 1, 1, 1, 1])
.with_max_def_level(3)
.with_max_rep_level(1)
.build()
```
_Originally posted by @alamb in
https://github.com/apache/arrow-rs/pull/9847#discussion_r3173223954_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
