alamb commented on PR #9908: URL: https://github.com/apache/arrow-rs/pull/9908#issuecomment-4382014092
> Happy to add a criterion microbenchmark too if it would help — the asymptotic story is straightforward (pre-sizing eliminates the O(value_capacity) resize+rehash chain on the first batch through each builder), but a synthetic bench could make it reproducible against the existing arrow-array bench suite. The value of a micro benchmark would be that we could potentially catch regressions. However, that also relies on us remembering to run the relevant benchmarks; I personally think not adding a micro benchmark is fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
