alamb commented on code in PR #9926:
URL: https://github.com/apache/arrow-rs/pull/9926#discussion_r3190862419
##########
arrow-buffer/src/buffer/mutable.rs:
##########
@@ -575,13 +630,26 @@ impl MutableBuffer {
}
/// Extends the buffer by `additional` bytes equal to `0u8`, incrementing
its capacity if needed.
+ ///
+ /// # Panics
+ ///
+ /// Panics if `self.len + additional` overflows `usize`, or if growing the
buffer requires
+ /// reserving a capacity that fails for the same reasons as
[`MutableBuffer::reserve`].
#[inline]
pub fn extend_zeros(&mut self, additional: usize) {
- self.resize(self.len + additional, 0);
+ let new_len = self
+ .len
+ .checked_add(additional)
Review Comment:
here is the new check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
