sdf-jkl commented on code in PR #8354:
URL: https://github.com/apache/arrow-rs/pull/8354#discussion_r3190982505
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -43,17 +46,75 @@ pub(crate) enum ShreddedPathStep<'a> {
NotShredded,
}
+/// Build the next shredding state by taking one list-like element (at
`index`) per input row.
+///
+fn take_list_like_index_as_shredding_state<L: ListLikeArray + 'static>(
+ typed_value: &dyn Array,
+ index: usize,
+) -> Result<Option<ShreddingState>> {
+ let list_array = typed_value.as_any().downcast_ref::<L>().ok_or_else(|| {
+ ArrowError::ComputeError(format!(
+ "Expected array type '{}' while handling list-like path step, got
'{}'",
+ std::any::type_name::<L>(),
+ typed_value.data_type()
+ ))
+ })?;
+
+ let values = list_array.values();
+
+ let Some(struct_array) = values.as_any().downcast_ref::<StructArray>()
else {
Review Comment:
Sounds good, I just copied the pattern from `follow_shredded_path_element`
`VariantPathElement::Field` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
