pitrou commented on code in PR #49919:
URL: https://github.com/apache/arrow/pull/49919#discussion_r3193618491
##########
cpp/src/arrow/stl_allocator.h:
##########
@@ -50,7 +60,7 @@ class allocator {
/// \brief Construct an allocator from the default MemoryPool
allocator() noexcept : pool_(default_memory_pool()) {}
/// \brief Construct an allocator from the given MemoryPool
- explicit allocator(MemoryPool* pool) noexcept : pool_(pool) {}
+ allocator(MemoryPool* pool) noexcept : pool_(pool) {} // NOLINT:
runtime/explicit
Review Comment:
Because it allows writing `PoolVector<c_type> chunk_values(pool());` without
having to spell out the `allocator` instantiation explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
