vanshaj2023 commented on PR #49462: URL: https://github.com/apache/arrow/pull/49462#issuecomment-4388767049
Hi @pitrou @tadeja @kou @zanmato1984 , apologies for the long silence on this PR, I was away for the last month and only just got back to it. Thanks for your patience and the careful reviews. I've just pushed an update that addresses the remaining feedback: @pitrou - re: the redundant SetLastError(original_error) before ARROW_LOG(FATAL) in thread_pool.cc: you're right, the process aborts so the restore is pointless. Removed it; the restore is now only on the success path. (commit fb06b05d86) @pitrou / @tadeja - re: the -Werror=comment from the multi-line // block in reader_test.cc: the trailing \ line continuations were already dropped in an earlier push on this branch. Could you re-check at the current HEAD? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
