alamb commented on PR #9678:
URL: https://github.com/apache/arrow-rs/pull/9678#issuecomment-4389558274
I had a few comments that github won't seem to let me post
It might help to explain what files it helps the most for:
```suggestion
/// The `path_in_schema` field in the Thrift metadata is redundant and
wastes a sometimes
/// significant amount of space, especially for files with long column
names or deeply nested
/// schema. Parquet file footers can be made smaller and easier to
/// parse by omitting this field.
```
It might help to be a little more specific about what readers this effects
```suggestion
/// Setting this to `false` will break compatibility with Parquet
readers that
/// still expect this field to be present. Many older Parquet readers,
such as parquet-java
/// but with the exception
/// of the one in this crate, expect this field to be present, and will
terminate execution
/// if it is not. This will continue to be the case unless/until the
Parquet format
/// specification is explicitly changed to allow this field to be
missing. As a consquence,
/// users should only set this to `false` if they have verified that any
reader(s) they plan
/// to use can tolerate the absence of this field.
///
/// For more context, see [GH-563].
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
