alamb commented on code in PR #9944:
URL: https://github.com/apache/arrow-rs/pull/9944#discussion_r3202400589


##########
dev/release/create-tarball.sh:
##########
@@ -79,6 +80,26 @@ 
url="https://dist.apache.org/repos/dist/dev/arrow/${release}-rc${rc}";
 echo "Attempting to create ${tarball} from tag ${tag}"
 
 
+# create <tarball> containing the files in git at $tag

Review Comment:
   This is just moved before the email template output because previously the 
sha 256 value was only computed *after* the email template was blatted out



##########
dev/release/create-tarball.sh:
##########
@@ -88,14 +109,17 @@ Subject: [VOTE][RUST] Release Apache Arrow Rust ${version} 
RC${rc}
 
 Hi,
 
-I would like to propose a release of Apache Arrow Rust Implementation, version 
${tag}.
+I would like to propose a release of Apache Arrow Rust Implementation, version 
${version}.

Review Comment:
   `tag` is like 56.1.0-rc1
   
   THis reads much easier in my opinoon



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to