thisisnic commented on code in PR #49937:
URL: https://github.com/apache/arrow/pull/49937#discussion_r3204519377
##########
cpp/src/arrow/builder.cc:
##########
@@ -188,8 +195,9 @@ struct DictionaryBuilderCase {
MemoryPool* pool;
const std::shared_ptr<DataType>& index_type;
const std::shared_ptr<DataType>& value_type;
- const std::shared_ptr<Array>& dictionary;
+ std::shared_ptr<Array> dictionary;
Review Comment:
This was updated as without it, we ended up with a dangling reference when
`nullptr` is passed in, like when we're creating a builder from a type and
don't have a dictionary array to pass in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
