Copilot commented on code in PR #49971:
URL: https://github.com/apache/arrow/pull/49971#discussion_r3230150645
##########
c_glib/test/test-extension-data-type.rb:
##########
@@ -27,15 +27,13 @@ def initialize
super(storage_data_type: Arrow::FixedSizeBinaryDataType.new(16))
end
- # TODO
- # def get_extension_name_impl
- # "uuid"
- # end
+ def virtual_do_get_extension_name
+ "uuid"
+ end
- # TODO
- # def get_array_gtype_impl
- # UUIDArray.gtype
- # end
+ def virtual_do_get_array_gtype
+ UUIDArray.gtype
+ end
Review Comment:
The `virtual_do_*` vfunc implementations are currently public. In other GLib
tests (e.g., `c_glib/test/helper/flight-server.rb`,
`c_glib/test/test-stream-decoder.rb`) these `virtual_do_*` methods are declared
under `private` to avoid exposing them as part of the Ruby surface area.
Consider adding `private` before these methods (or marking them private
individually) for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
