etseidl commented on PR #9967:
URL: https://github.com/apache/arrow-rs/pull/9967#issuecomment-4447694381
Sorry @RyanJamesStewart I led you astray. I think the regression is due to
the `nulls.slice()` call in the not-enough-nulls arm. If you revert that to the
original, most of the regression goes away (at least on my machine).
```rust
} else {
let nulls = nulls.inner();
info.def_levels.extend_from_iter(range.clone().map(|i| {
// Safety: range.end was asserted to be in
bounds earlier
let valid = unsafe { nulls.value_unchecked(i) };
max_def_level - (!valid as i16)
}));
info.non_null_indices.reserve(len);
info.non_null_indices.extend(
BitIndexIterator::new(nulls.inner(),
nulls.offset() + range.start, len)
.map(|i| i + range.start),
);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
