etseidl commented on code in PR #9974:
URL: https://github.com/apache/arrow-rs/pull/9974#discussion_r3243124101
##########
parquet/src/parquet_thrift.rs:
##########
@@ -175,25 +176,27 @@ impl TryFrom<u8> for FieldType {
10 => Ok(Self::Set),
11 => Ok(Self::Map),
12 => Ok(Self::Struct),
+ 13 => Ok(Self::Uuid),
_ => Err(ThriftProtocolError::InvalidFieldType(value)),
}
}
}
-impl TryFrom<ElementType> for FieldType {
- type Error = ThriftProtocolError;
- fn try_from(value: ElementType) -> std::result::Result<Self, Self::Error> {
+impl From<ElementType> for FieldType {
+ fn from(value: ElementType) -> Self {
Review Comment:
This conversion can now be infallible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
