alamb commented on PR #9689: URL: https://github.com/apache/arrow-rs/pull/9689#issuecomment-4453481484
> @alamb @scovich This modification was to let arrow-cast and variant reuse the same code. So do we need to keep the current logic in current pr now, or revert the logic in arrow-cast, and maintain the single_decimal_to_integer seperate in arrow-cast and variant? I think it would be safest to revert the change in arrow-cast (even if we have to maintain two separate copies) This is because otherwise someone might see a performance regression and when they track it down to this PR and there is no benefit other than to the maintenance of the code. It is hard to justify such changes I think -- it is better if we keep the behavior the same/better for downstream users even it if makes the code harder to maintain ANother potential option (maybe not as nice) could be to use a macro to avoid duplication -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
