alamb commented on PR #9865: URL: https://github.com/apache/arrow-rs/pull/9865#issuecomment-4453766046
Yeah, in general I don't think we should be moving large amounts of code (and the comparator code gets used a lot) into the arrow-array module as that will have the effect of increasing binary sizes / compile times for downstream users who are are not compiling the entire arrow crate and not using REE How about this: 1. Pull out the kernels needed for REE into their own crates (`arrow-ord-basic` or `arrow-ord-ree`) 2. Add a optional depenedency on those crates to anything that only needs if for ree (behind an `ree` feature flag perhaps) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
