lidavidm commented on code in PR #802:
URL: https://github.com/apache/arrow-go/pull/802#discussion_r3199018608
##########
arrow/compute/exec/span.go:
##########
@@ -579,6 +579,13 @@ func getNumBuffers(dt arrow.DataType) int {
return 1
case arrow.BINARY, arrow.LARGE_BINARY, arrow.STRING,
arrow.LARGE_STRING, arrow.DENSE_UNION:
return 3
+ case arrow.BINARY_VIEW, arrow.STRING_VIEW:
+ // bitmap + view-header buffer + a single overflow data buffer.
+ // ArraySpan's fixed buffer array limits additional data
buffers,
+ // so callers producing multi-buffer views must keep their data
+ // within a single block (the default 32KB allocation in the
+ // builder is sufficient for most use cases).
Review Comment:
Is it? It seems we need to address this at some point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
