alamb commented on code in PR #9968:
URL: https://github.com/apache/arrow-rs/pull/9968#discussion_r3250558429
##########
parquet/src/arrow/push_decoder/reader_builder/mod.rs:
##########
@@ -291,11 +324,52 @@ impl RowGroupReaderBuilder {
}
}
+ /// Decompose into [`RowGroupReaderBuilderParts`].
+ ///
+ /// The runtime decode `state` is discarded; the configuration that came
+ /// from the [`ParquetPushDecoderBuilder`] and the buffered bytes are
+ /// returned so the builder can be reconstructed.
+ ///
+ /// [`ParquetPushDecoderBuilder`]:
crate::arrow::push_decoder::ParquetPushDecoderBuilder
+ pub(crate) fn into_parts(self) -> RowGroupReaderBuilderParts {
+ let Self {
Review Comment:
it might be worth a comment here and in the other `into_parts` function that
if a new field gets added, it should also be threaded back into
`RowGroupReaderBuilderParts` (not ignored)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
