oakad commented on PR #805: URL: https://github.com/apache/arrow-go/pull/805#issuecomment-4475877920
I have added a unit test. I also had to alter the `NewRecordBatch`s semantics slightly, as I could not get rid from memory leak otherwise - after the panic in there was raised, the remaining memory state was somehow nonobviously inconsistent. Also, it feels that current approach (check row counts ahead of any array move action) feels generally safer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
