davidhcoe commented on code in PR #4322:
URL: https://github.com/apache/arrow-adbc/pull/4322#discussion_r3261982303


##########
go/adbc/adbc.go:
##########
@@ -264,6 +264,28 @@ const (
        OptionKeyPassword                 = "password"
        // EXPERIMENTAL. Sets/Gets the trace parent on OpenTelemetry traces
        OptionKeyTelemetryTraceParent = "adbc.telemetry.trace_parent"
+       // EXPERIMENTAL. Selects the OpenTelemetry traces exporter when the
+       // driver initializes its tracer provider. Accepts the same values as
+       // the OpenTelemetry "OTEL_TRACES_EXPORTER" environment variable (see
+       // the OptionTelemetryExporter constants below: "none", "otlp",
+       // "console", "adbcfile"). When this option is set on a database it
+       // takes precedence over the OTEL_TRACES_EXPORTER environment
+       // variable, which lets operators select an exporter via the ADBC
+       // driver manager / TOML profile mechanism without having to mutate
+       // the host process's environment. When neither this option nor the
+       // environment variable is set, the driver falls back to the
+       // process-global OpenTelemetry tracer provider.
+       OptionKeyTelemetryTracesExporter = "adbc.telemetry.traces_exporter"

Review Comment:
   This is so we can pass values using the driver manager / TOML values and not 
need to use environment variables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to