ernestprovo23 commented on PR #49372: URL: https://github.com/apache/arrow/pull/49372#issuecomment-4486741057
@rok Pushed an update for the Cython binding issue causing the build failures. The `cpp_string_view` cppclass in `python/pyarrow/includes/common.pxd` has the known-broken constructor declarations referenced by the [cython/cython#6651](https://github.com/cython/cython/issues/6651) comment right above it — the inner declarations are named `string_view(...)` rather than `cpp_string_view(...)` so Cython parses them as methods, not constructors. Result: `cpp_string_view(c_path)` failed with `no constructor found for C++ type 'cpp_string_view'` and then crashed the Cython compiler downstream. Switched the `CIsLikelyUri` binding to take `const c_string&`; C++17's implicit `std::string -> std::string_view` conversion handles the call at the C++ level, so the actual C++ signature is unchanged. Verified locally that Cython now compiles `_fs.pyx` cleanly. Also rebased on main. Two remaining CI failures look pre-existing and unrelated to this PR — flagging in case it saves you a click: - `AMD64 Ubuntu Meson` — `cpp/src/arrow/extension/meson.build:27` references a missing `fixed_shape_tensor_test.cc` - `ARM64 macOS 14 *` — `cpp/src/arrow/flight/transport/grpc/serialization_internal.cc:356` `nodiscard` warning treated as error Happy to add an inline comment in `_fs.pyx` referencing `cython/cython#6651` if you'd prefer the workaround documented at the call site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
