jonkeane commented on code in PR #49982:
URL: https://github.com/apache/arrow/pull/49982#discussion_r3266717776
##########
dev/tasks/tasks.yml:
##########
@@ -651,6 +651,10 @@ tasks:
env:
CMAKE_BUILD_TYPE: MinSizeRel
+ test-r-r-universe-wasm:
Review Comment:
```suggestion
test-r-universe-wasm:
```
I know how we got here, but the `-r-r-` seemed a little silly. We could also
call this `test-r-wasm` yeah? I know we are using r-universe's build machinery
to accomplish this, but it's really the only r + wasm test right?
##########
r/inst/build_arrow_static.sh:
##########
@@ -74,6 +77,9 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DARROW_CSV=ON \
-DARROW_DATASET=${ARROW_DATASET:-ON} \
-DARROW_DEPENDENCY_SOURCE=${ARROW_DEPENDENCY_SOURCE:-AUTO} \
+ -DARROW_DEPENDENCY_USE_SHARED=${ARROW_DEPENDENCY_USE_SHARED:-ON} \
+ -DARROW_ENABLE_THREADING=${ARROW_ENABLE_THREADING:-ON} \
+ -DARROW_FLIGHT=${ARROW_FLIGHT:-OFF} \
Review Comment:
Were these defaults we were getting already via the cmake? Or are these
actually enabling / disabling things?
OH, I see for `ARROW_ENABLE_THREADING` that would have defaulted to on, but
we need to set it to off for wasm in `nixlibs.r` and same with
`ARROW_DEPENDENCY_USE_SHARED`. But what about `ARROW_FLIGHT` ? It doesn't look
like that is (over)ridden down below? I'm fine with it being here (I think it
_would_ default to off), but that's slightly separate from this PR, yeah? Or am
I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
