KyleFromNVIDIA commented on code in PR #49993:
URL: https://github.com/apache/arrow/pull/49993#discussion_r3274413061
##########
cpp/cmake_modules/FindRapidJSONAlt.cmake:
##########
@@ -26,7 +26,10 @@ endif()
if(RapidJSONAlt_FIND_QUIETLY)
list(APPEND find_package_args QUIET)
endif()
+set(_CMAKE_POLICY_VERSION_MINIMUM_OLD ${CMAKE_POLICY_VERSION_MINIMUM})
+set(CMAKE_POLICY_VERSION_MINIMUM 3.5)
find_package(RapidJSON ${find_package_args})
+set(CMAKE_POLICY_VERSION_MINIMUM ${_CMAKE_POLICY_VERSION_MINIMUM_OLD})
Review Comment:
Bad review. Since `${_CMAKE_POLICY_VERSION_MINIMUM_OLD}` is unquoted, if
it's unset, `CMAKE_POLICY_VERSION_MINIMUM` will be unset rather than being set
to an empty string. There is no scenario where `CMAKE_POLICY_VERSION_MINIMUM`
being an empty string is valid, so the existing code covers all valid scenarios
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
