egolearner commented on code in PR #49858:
URL: https://github.com/apache/arrow/pull/49858#discussion_r3275313922
##########
python/pyarrow/_dataset.pyx:
##########
@@ -2253,6 +2253,8 @@ cdef class CsvFileFormat(FileFormat):
"""
cdef CsvFileWriteOptions opts = \
<CsvFileWriteOptions> FileFormat.make_write_options(self)
+ if kwargs.get('delimiter') is None:
+ kwargs['delimiter'] = opts.write_options.delimiter
Review Comment:
Good point — generalized it. Now we start from the C++ default
`WriteOptions` and overwrite with caller-provided kwargs on top via `setattr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
