alamb commented on code in PR #9994:
URL: https://github.com/apache/arrow-rs/pull/9994#discussion_r3276528054
##########
arrow-schema/src/datatype.rs:
##########
@@ -722,6 +722,13 @@ impl DataType {
})
})
}
+ // Timestamps with matching unit whose timezones are both
recognized UTC
Review Comment:
It seems to me that this cast / comparsion should be done at the
application layer (aka the thing calling the parquet writer). My rationale is
that there are many other places in the codbase that compare arrays based on
exact equality of DataType, and don't do this timezone normalization.
Perhaps in the iceberg code you could add a call to
[`cast`](https://docs.rs/arrow/latest/arrow/compute/kernels/cast/fn.cast.html)
for all columns before you pass it to the parquet writer . The `cast` is a noop
for arrays of the already correct type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
