scovich commented on code in PR #9663:
URL: https://github.com/apache/arrow-rs/pull/9663#discussion_r3277015677
##########
parquet-variant-compute/src/shred_variant.rs:
##########
@@ -328,19 +328,14 @@ impl<'a> VariantToShreddedArrayVariantRowBuilder<'a> {
// If the variant is not an array, typed_value must be null.
// If the variant is an array, value must be null.
match variant {
- Variant::List(ref list) => {
+ Variant::List(list) => {
self.nulls.append_non_null();
+ self.value_builder.append_null();
- // With `safe` cast option set to false, appending list of
wrong size to
- // `typed_value_builder` of type `FixedSizeList` will result
in an error. In such a
- // case, the provided list should be appended to the
`value_builder.
- let shredded =
self.typed_value_builder.append_value(&variant)?;
- if shredded {
- self.value_builder.append_null();
- } else {
-
self.value_builder.append_value(Variant::List(list.clone()));
- }
- Ok(shredded)
+ // NOTE: A `FixedSizeList` with incorrect size will hard fail
during shredding.
+ self.typed_value_builder
+ .append_value(&Variant::List(list))?;
Review Comment:
Aside: a bit surprised fmt liked this line break?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
