HippoBaro commented on code in PR #9955:
URL: https://github.com/apache/arrow-rs/pull/9955#discussion_r3277177627
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -165,7 +165,7 @@ impl FallbackEncoder {
}
/// Encode `values` to the in-progress page
- fn encode<T>(&mut self, values: T, indices: &[usize])
+ fn encode<T>(&mut self, values: T, indices: impl ExactSizeIterator<Item =
usize>)
Review Comment:
Yes apologies for being lazy with my PR descriptions... That is accurate.
The next PR in the series will use this so that we avoid materializing
intermediary `[usize]` in the cases where that's possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
