davidhcoe commented on code in PR #4340:
URL: https://github.com/apache/arrow-adbc/pull/4340#discussion_r3277266538
##########
csharp/src/Apache.Arrow.Adbc/DriverManager/TomlParser.cs:
##########
@@ -140,29 +152,59 @@ private static void ValidateSectionName(string
sectionName)
}
}
+ private static void ValidateKeyName(string keyName)
+ {
+ // Only bare keys are supported. Dotted, quoted, and
whitespace-containing
+ // keys are recognized TOML productions that this parser
deliberately rejects
+ // rather than misinterpret.
+ if (keyName.Length == 0)
+ {
+ throw new FormatException("Invalid TOML key: key is empty.");
+ }
+
+ for (int i = 0; i < keyName.Length; i++)
Review Comment:
Doesn't this mean we can't use the property names as keys then we can't set
`adbc.snowflake.sql.warehouse = "foo"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
