Copilot commented on code in PR #47482:
URL: https://github.com/apache/arrow/pull/47482#discussion_r3285326054
##########
cpp/src/arrow/acero/source_node.cc:
##########
@@ -408,7 +408,7 @@ struct SchemaSourceNode : public SourceNode {
struct RecordBatchReaderSourceNode : public SourceNode {
RecordBatchReaderSourceNode(ExecPlan* plan, std::shared_ptr<Schema> schema,
arrow::AsyncGenerator<std::optional<ExecBatch>>
generator)
- : SourceNode(plan, schema, generator) {}
+ : SourceNode(plan, schema, generator, Ordering::Implicit()) {}
Review Comment:
This change fixes Fetch validation by marking the source as implicitly
ordered, but there isn't a regression test exercising
`record_batch_reader_source` + `fetch` (limit/offset). Please add a test that
builds a plan with `record_batch_reader_source` feeding a `fetch` node (ideally
in both serial and threaded/jittered execution) and asserts the resulting table
matches `Table::Slice` semantics, to prevent this from regressing again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
