Copilot commented on code in PR #49603:
URL: https://github.com/apache/arrow/pull/49603#discussion_r3285555842
##########
dev/release/07-flightsqlodbc-upload.sh:
##########
@@ -136,15 +136,15 @@ if [ "${PHASE_SIGN_DLL}" -gt 0 ]; then
fi
if [ "${PHASE_BUILD_MSI}" -gt 0 ]; then
- echo "[4/8 Triggering odbc_release_step in cpp_extra.yml workflow..."
- gh workflow run cpp_extra.yml \
+ echo "[4/8 Triggering odbc_release_step in package_odbc.yml workflow..."
Review Comment:
The progress log message is missing a closing bracket (it prints `[4/8 ...`
rather than `[4/8] ...`). Consider aligning it with the typical `[n/8]` format
for readability.
##########
.github/workflows/cpp_extra.yml:
##########
@@ -789,6 +696,8 @@ jobs:
- odbc-linux
- odbc-macos
- odbc-msvc
+ - odbc-msvc-upload-dll
+ - odbc-msvc-upload-msi
Review Comment:
`report-extra-cpp.needs` includes `odbc-msvc-upload-dll` and
`odbc-msvc-upload-msi`, but those jobs are not defined anywhere in
`cpp_extra.yml` (they exist in `package_odbc.yml`). GitHub Actions will fail
workflow validation with “Job depends on unknown job”. Remove these entries
from `needs` (or define the jobs in this workflow if they are intended to be
part of it).
##########
.github/workflows/package_odbc.yml:
##########
@@ -0,0 +1,197 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Package ODBC
+
+on:
+ push:
+ branches:
+ - '**'
+ - '!dependabot/**'
+ paths:
+ - '.github/actions/odbc-windows/action.yml'
+ - '.github/workflows/check_labels.yml'
+ - '.github/workflows/cpp_extra.yml'
+ - '.github/workflows/report_ci.yml'
+ - 'ci/scripts/ccache_setup.sh'
+ - 'ci/scripts/cpp_*'
+ - 'ci/scripts/download_tz_database.sh'
+ - 'ci/scripts/install_ccache.sh'
+ - 'cpp/**'
+ - 'format/Flight.proto'
+ - 'testing'
Review Comment:
The `push.paths` filter doesn’t include `.github/workflows/package_odbc.yml`
itself. As a result, changes to this workflow file won’t trigger the workflow
on pushes (making it harder to validate updates). Add this workflow file to the
`paths` list to match the pattern used by other workflows (e.g., `cpp.yml`,
`package_linux.yml`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
