ianmcook commented on a change in pull request #10190:
URL: https://github.com/apache/arrow/pull/10190#discussion_r629369624
##########
File path: r/src/compute.cpp
##########
@@ -233,6 +233,33 @@ std::shared_ptr<arrow::compute::FunctionOptions>
make_compute_options(
max_replacements);
}
+ if (func_name == "split_pattern") {
+ using Options = arrow::compute::SplitPatternOptions;
+ int64_t max_splits = -1;
Review comment:
That all makes good sense to me but I'm not up to speed on what design
conventions we follow in the C++ compute functions. Maybe it'd be best to start
a Zulip thread to ask folks about this (Joris, Antonie, Maarten Breddels) to
get a better idea of the best change to suggest (if any).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
