CynicDog commented on code in PR #9985:
URL: https://github.com/apache/arrow-rs/pull/9985#discussion_r3288194748
##########
parquet/src/arrow/schema/primitive.rs:
##########
@@ -168,6 +168,16 @@ fn decimal_256_type(scale: i32, precision: i32) ->
Result<DataType> {
Ok(DataType::Decimal256(precision, scale))
}
+fn check_decimal_length(type_length: i32) -> Result<()> {
+ // Arrow's widest decimal is Decimal256, which needs at most 32 bytes.
+ if !(1..=32).contains(&type_length) {
Review Comment:
Makes sense, updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
