alinaliBQ commented on code in PR #49787:
URL: https://github.com/apache/arrow/pull/49787#discussion_r3290575631
##########
cpp/src/arrow/flight/sql/odbc/CMakeLists.txt:
##########
@@ -155,10 +155,11 @@ if(ARROW_FLIGHT_SQL_ODBC_INSTALLER)
set(CPACK_WIX_UI_BANNER
"${CMAKE_CURRENT_SOURCE_DIR}/install/windows/arrow-wix-banner.bmp")
else()
+ set(ODBC_UNIX_FILE_NAME
+
"ArrowFlightSqlOdbc-${CPACK_PACKAGE_VERSION_MAJOR}.${ODBC_PACKAGE_VERSION_MINOR}.${ODBC_PACKAGE_VERSION_PATCH}"
+ )
Review Comment:
```suggestion
set(ODBC_UNIX_FILE_NAME
"ArrowFlightSQLODBC-${CPACK_PACKAGE_VERSION_MAJOR}.${ODBC_PACKAGE_VERSION_MINOR}.${ODBC_PACKAGE_VERSION_PATCH}"
)
```
##########
.github/workflows/cpp_extra.yml:
##########
@@ -392,7 +401,14 @@ jobs:
# GH-40558: reduce ASLR to avoid ASAN/LSAN crashes
sudo sysctl -w vm.mmap_rnd_bits=28
source ci/scripts/util_enable_core_dumps.sh
- archery docker run ubuntu-cpp-odbc
+ archery docker run ${{ matrix.run-options || '' }} ${{ matrix.image
}}
+ - name: Upload ODBC ${{ matrix.format }} to the job
+ if: matrix.build-type == 'release'
+ uses: actions/upload-artifact@v7
+ with:
+ name: flight-sql-odbc-${{ matrix.format }}-installer
+ path: build/cpp/ArrowFlightSqlOdbc-*.${{ matrix.format }}
Review Comment:
```suggestion
path: build/cpp/ArrowFlightSQLODBC-*.${{ matrix.format }}
```
##########
cpp/src/arrow/flight/sql/odbc/README.md:
##########
@@ -144,6 +144,22 @@ After ODBC has been registered, you can run the ODBC
tests. It is recommended to
.\cpp\build\< release | debug >\< Release |
Debug>\arrow-flight-sql-odbc-test.exe
```
+## Installers
+
+ODBC installers are uploaded to the CI artifacts.
+
+| Operating System | Package Format |
+|------------------|----------------|
+| Windows | MSI |
+| macOS | PKG |
+| Linux | DEB / RPM |
+
+### Install `.RPM` on Ubuntu
+While installing via `.DEB` installer on Ubuntu is the recommended approach,
users may install `.RPM` on Ubuntu using below command
+```
+alien -i --scripts ArrowFlightSqlOdbc-<version>.rpm
Review Comment:
```suggestion
alien -i --scripts ArrowFlightSQLODBC-<version>.rpm
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
