vanshaj2023 commented on PR #49357: URL: https://github.com/apache/arrow/pull/49357#issuecomment-4522055319
Hi @rok, I've reviewed #49453 and it fully addresses the original issue in a cleaner way than this PR. The migration to scikit-build-core eliminates the MANIFEST.in distribution problem, the CMake-based injection removes the fragile dynamic import from setup.py, and PYARROW_REQUIRE_STUB_DOCSTRINGS=OFF makes libcst entirely opt-in by default. All three problems this PR was trying to solve are now handled upstream. Closing this in favor of the approach landed in #49453. Thanks for the guidance throughout! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
