pitrou commented on a change in pull request #10284:
URL: https://github.com/apache/arrow/pull/10284#discussion_r629428714
##########
File path: cpp/src/arrow/dataset/file_csv_test.cc
##########
@@ -223,6 +223,24 @@ N/A
EXPECT_EQ(*actual, Schema({field("f64", float64())}));
}
+TEST_P(TestCsvFileFormat, InspectWithCustomConvertOptions) {
+ // Regression test for ARROW-12083
+ auto source = GetFileSource(R"(actually_string
+1.0
+
+N/A
+2
+whoops)");
+ auto defaults = std::make_shared<CsvFragmentScanOptions>();
+ // Prevent type inference from seeing the string value
+ defaults->read_options.block_size = 20;
+ // Override the inferred type
+ defaults->convert_options.column_types["actually_string"] = utf8();
Review comment:
Should we also test the behaviour without this option set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
