lidavidm commented on code in PR #50021:
URL: https://github.com/apache/arrow/pull/50021#discussion_r3296463436
##########
cpp/src/arrow/flight/sql/odbc/tests/connection_info_test.cc:
##########
Review Comment:
It seems there's some failing tests - some more test cases need updating?
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/get_info_cache.cc:
##########
@@ -395,25 +395,21 @@ bool GetInfoCache::LoadInfoFromServer() {
// Unused by ODBC.
break;
case SqlInfoOptions::SQL_DDL_SCHEMA: {
- // GH-49500 TODO: use scalar bool to determine
`SQL_CREATE_SCHEMA` and
- // `SQL_DROP_SCHEMA` values
-
- // Note: this is a bitmask and we can't describe cascade or
restrict
- // flags.
- info_[SQL_DROP_SCHEMA] =
static_cast<uint32_t>(SQL_DS_DROP_SCHEMA);
-
- // Note: this is a bitmask and we can't describe authorization or
- // collation
- info_[SQL_CREATE_SCHEMA] =
static_cast<uint32_t>(SQL_CS_CREATE_SCHEMA);
+ bool supported =
+
reinterpret_cast<BooleanScalar*>(scalar->child_value().get())->value;
Review Comment:
Maybe we can use checked_cast from arrow/util/checked_cast.h?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
