Copilot commented on code in PR #50053: URL: https://github.com/apache/arrow/pull/50053#discussion_r3313389419
########## ci/scripts/install_bison.sh: ########## @@ -0,0 +1,41 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -e + +if [ "$#" -ne 2 ]; then + echo "Usage: $0 <version> <prefix>" + exit 1 +fi + +version=$1 +prefix=$2 + +mkdir -p /tmp/bison +url="https://ftp.gnu.org/gnu/bison/bison-${version}.tar.gz"; + +wget -q "${url}" -O - | tar -xzf - --directory /tmp/bison --strip-components=1 + Review Comment: The bison source tarball is downloaded and extracted via a `wget | tar` pipeline without `pipefail` and without any integrity verification (checksum or signature). This makes the build more fragile and introduces a supply-chain risk if the download is corrupted or tampered with. Consider switching to a `curl --fail --location` download and verifying a published checksum/signature (and enabling `set -o pipefail` for the pipeline). ########## ci/scripts/install_bison.sh: ########## @@ -0,0 +1,41 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +set -e + +if [ "$#" -ne 2 ]; then + echo "Usage: $0 <version> <prefix>" + exit 1 +fi + +version=$1 +prefix=$2 + +mkdir -p /tmp/bison +url="https://ftp.gnu.org/gnu/bison/bison-${version}.tar.gz"; + +wget -q "${url}" -O - | tar -xzf - --directory /tmp/bison --strip-components=1 + +pushd /tmp/bison +./configure --prefix="${prefix}" +make -j$(nproc) +make install +popd + +rm -rf /tmp/bison Review Comment: This script uses a fixed working directory (`/tmp/bison`) and only cleans it up at the end. If `configure`/`make` fails, the directory is left behind, and using a predictable /tmp path can also be problematic. Consider using `tmpdir=$(mktemp -d)` plus a `trap` to ensure cleanup on error/exit, and use that directory consistently for extract/build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
