n3world commented on a change in pull request #10255:
URL: https://github.com/apache/arrow/pull/10255#discussion_r629540920
##########
File path: cpp/src/arrow/csv/reader_test.cc
##########
@@ -216,5 +216,83 @@ TEST(StreamingReaderTests, NestedParallelism) {
TestNestedParallelism(thread_pool, table_factory);
}
+TEST(ReaderOptionsTests, SkipRowsAfterNames) {
Review comment:
OK. I think the skip still needs to be moved to the parser though so
that escaped or quoted new lines are properly handled. Also, should it be an
error to provide `skip_rows` and `skip_rows_after_names` at the same time if
names are not being parsed from the csv? There is no reason they both cannot be
provided it just seems strange to use both and might indicate a lack of
understanding by the user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
