tokoko commented on code in PR #4317:
URL: https://github.com/apache/arrow-adbc/pull/4317#discussion_r3322120071
##########
c/include/arrow-adbc/adbc.h:
##########
@@ -1135,6 +1146,30 @@ struct ADBC_EXPORT AdbcDriver {
struct AdbcError*);
/// @}
+
+ /// \defgroup adbc-1.2.0 ADBC API Revision 1.2.0
+ ///
+ /// Functions added in ADBC 1.2.0. For backwards compatibility,
+ /// these members must not be accessed unless the version passed to
+ /// the AdbcDriverInitFunc is greater than or equal to
+ /// ADBC_VERSION_1_2_0.
+ ///
+ /// @{
+
+ AdbcStatusCode (*ConnectionBeginIngestPartitions)(
+ struct AdbcConnection*, const char*, const char*, const char*, const
char*,
+ struct ArrowSchema*, struct AdbcIngestHandle*, struct AdbcError*);
+ AdbcStatusCode (*ConnectionWriteIngestPartition)(
+ struct AdbcConnection*, const uint8_t*, size_t, struct ArrowArrayStream*,
+ struct AdbcIngestReceipt*, struct AdbcError*);
+ AdbcStatusCode (*ConnectionCommitIngestPartitions)(
Review Comment:
wdyt about "complete" or maybe "apply"? I'm fine with changing to "complete"
if you agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
