dmatth1 commented on code in PR #10011:
URL: https://github.com/apache/arrow-rs/pull/10011#discussion_r3323884061
##########
parquet/benches/bloom_filter.rs:
##########
@@ -104,10 +108,123 @@ fn bench_insert_only(c: &mut Criterion) {
group.finish();
}
+/// Benchmark `Sbbf::insert` across the same three cache regimes as
Review Comment:
Mainly for conciseness? Or should we push the bench changes first, then this
Sbbf probe change second that way its easy to compare? Otherwise I'd lean
towards keeping it in here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
