pitrou commented on PR #49679: URL: https://github.com/apache/arrow/pull/49679#issuecomment-4593841890
To alleviate this combinatorial explosion, it seems several axes of code generation can be decoupled: - the `EmitNulls` templating (is it useful at all?) - physical-to-logical conversion for REE values: this can be done after the physical values search, and needn't be templated on the `ArrowType` Also, one important improvement is to use `GetPhysicalType` to avoid generating separate code paths for e.g. `int32` vs. `date32`, `int64` vs. `timestamp`, `binary` vs. `string`, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
