Copilot commented on code in PR #50047:
URL: https://github.com/apache/arrow/pull/50047#discussion_r3341029451
##########
.github/workflows/cpp.yml:
##########
@@ -119,12 +120,11 @@ jobs:
persist-credentials: false
fetch-depth: 0
submodules: recursive
- - name: Cache Docker Volumes
- uses: actions/cache@v5
+ - name: Restore Docker Volumes
+ uses:
apache/infrastructure-actions/stash/restore@0ba14156c9f4c3cfbe4b0c9f36339ab0f8d81e53
with:
path: .docker
- key: ${{ matrix.image }}-${{ hashFiles('cpp/**') }}
- restore-keys: ${{ matrix.image }}-
+ key: ${{ matrix.image }}
- name: Setup Python on hosted runner
Review Comment:
The Docker volume cache key is inconsistent between restore and save, so
restores will never pick up the cache produced by this workflow run. `Restore
Docker Volumes` uses `${{ matrix.image }}` while `Save Docker Volumes` uses
`cpp-${{ matrix.image }}`; as a result, cache effectiveness for `.docker` will
be near-zero (only keys that happen to match externally would restore).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
